Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces the healthconnect module, providing integration with the Health Connect API. Key additions include managers for handling data changes and records, a background worker for periodic reads, and a companion service for wearable devices. Feedback focuses on correcting a package name error in the theme configuration, removing duplicate dependencies and unused imports, and cleaning up unused constructor parameters in the manager classes. Additionally, a misleading comment regarding an early return in the UI logic should be clarified.
kkuan2011
left a comment
kkuan2011
left a comment
There was a problem hiding this comment.
I ran the GitHub workflows, and it looks like the spotless check failed as well as the build. I have a suggestion for fixing the build, but not sure about the spotless check error. I wonder if you have to squash all your commits into 1 commit, and then force push the branch again, so that there's only 1 commit on top of main?
| @@ -0,0 +1,37 @@ | |||
| package com.example.healthconnect | |||
There was a problem hiding this comment.
please add copyright header
| @@ -0,0 +1,37 @@ | |||
| package com.example.healthconnect.ui.theme | |||
| @@ -0,0 +1,139 @@ | |||
| /* | |||
| * Copyright 2026 The Android Open Source Project | |||
There was a problem hiding this comment.
the copyright header needs to be the full text of the copyright notice (I believe it's about 15 lines long)
| @@ -0,0 +1,102 @@ | |||
| /* | |||
| * Copyright 2026 The Android Open Source Project | |||
There was a problem hiding this comment.
use full length version of the copyright header
| @@ -0,0 +1,45 @@ | |||
| package com.example.healthconnect | |||
|
|
|||
There was a problem hiding this comment.
add copyright header for this file and all other files missing it too please
| private var healthConnectClient: HealthConnectClient? = null | ||
| private var bluetoothGatt: BluetoothGatt? = null | ||
|
|
||
| @Deprecated("Deprecated in Java") |
There was a problem hiding this comment.
how come we have this deprecated annotation?
|
|
||
| android { | ||
| namespace = "com.example.healthconnect" | ||
| compileSdkPreview = "CinnamonBun" |
There was a problem hiding this comment.
The build is failing, so I think you need a change similar to this one:
f6e34d2
3 participants
Add Health Connect snippets to main.